Repository navigation
fix: show the claimant their own claim, not the loser's message - #741
Open
smartcalsystems-sketch wants to merge 1 commit into
Open
smartcalsystems-sketch wants to merge 1 commit into
smartcalsystems-sketch wants to merge 1 commit into
Conversation
MergeFi#699) When status === 'claimed', ClaimButton showed "This bounty has already been claimed" / "Claimed by: ..." to everyone, including the person who claimed it -- once the 5s success notice expires, or on any later visit, the contributor doing the work sees wording written for the people who lost the race, with no guidance on what to do next. Compare bounty.claimedById against user.id: the claimant now sees a distinct "You're working on this" panel with the Fixes #N PR instruction, while everyone else (a different signed-in user, or signed out) still sees the existing generic already-claimed view.
|
@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
status === 'claimed',ClaimButtonshows "This bounty has already been claimed" / "Claimed by: …" to everyone, including the claimant — after the 5s success notice expires, or on any later visit. The person doing the work gets wording meant for losers of the race, and no "Open a pull request that saysFixes #N" guidance.Fix
Compares
bounty.claimedByIdwithuser.id. When they match, renders a distinct "You're working on this" panel with the specificFixes #<issueNumber>instruction and a note that the reward releases automatically on merge. Everyone else (a different signed-in user, or a signed-out visitor) still sees the existing generic already-claimed view unchanged.Testing
ClaimButton.test.tsxsuite: 24/24 passing (21 pre-existing + 3 new), zero regressions.tsc --noEmitandeslintclean on both changed files.Closes #699